Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aeraki support specified namespace #326

Merged
merged 1 commit into from
Apr 3, 2023
Merged

aeraki support specified namespace #326

merged 1 commit into from
Apr 3, 2023

Conversation

tanjunchen
Copy link
Member

What this PR does / Why we need it:

Pre-Submission Checklist:

image

  • Did you explain what problem does this PR solve? Or what new features have been added?
  • Have you added related test cases?
  • Have you modified the related document?
  • Is this PR backward compatible?

@mergify mergify bot requested a review from zhaohuabing March 30, 2023 08:00
@tanjunchen tanjunchen force-pushed the master branch 10 times, most recently from 12fb747 to ba12651 Compare March 31, 2023 12:14
@tanjunchen
aeraki support specified namespace
1b79990 
Signed-off-by: chentanjun <tanjunchen20@gmail.com>
zhaohuabing
zhaohuabing approved these changes Apr 3, 2023
View reviewed changes
Copy link
Member

@zhaohuabing zhaohuabing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaohuabing zhaohuabing merged commit c0b0898 into aeraki-mesh:master Apr 3, 2023
@tanjunchen tanjunchen mentioned this pull request Apr 23, 2023
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaohuabing zhaohuabing zhaohuabing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tanjunchen @zhaohuabing